My first PR for Hacktoberfest

Finding the first issue to work with

As a beginner in the open-source project development, it is really hard to find something that I comfortable working with. I found out that there are so many competitors on a lot of issues, and it struggled me a while. I finally noticed that I can sort the issues by newest, then there would be much fewer competitors. 

The first issue I was working on is that reduce the size of an ASCII logo of onefetch repository. Since the logo exceeds the max size imposed by their Guideline, the project owner wants to reduce the size of the logo with a width < MAX_WIDTH = 40 and height < MAX_HEIGHT = 25.  



Since I am not a creative person, I asked the owner that is he accepts a size down of the original logo or he wants a completely new logo. And he assigns the issue to me since he just wants a size down of the original logo.

Working on my first issue

 after I got assigned, I just realized the project is written in Rust which I never try about. I started to download and learned some commands of Rust project. I don't really need to know the much about Rust, but I need to at least know how to build and test my output. 

I found the maximum width of the original log is 47, I reduced the longest line to 40 first then adjust the rest lines to look similar to the original logo. Even the issue is not difficult,  it still took me a few hours to finish.

I also used their command "cargo test -- --ignored" to test is the logo size suitable. 


Sending my first PR

I end up with 3 different versions because I don't have any confidence in my artistic ability. Before I send the PR, I cautiously asked the owner is satisfied with my logo. He said "Looks perfect!

Looking forward to merge your PR". I was so happy that my work gets approved. 

I finally send my PR Reduce size of Nim's ASCII logo, with the issue number, output image, test result. The owner merged it n a few mins and thanked me for my contribution.

Links

the Repo: https://github.com/o2sh/onefetch

the Issue: https://github.com/o2sh/onefetch/issues/250

the PR: https://github.com/o2sh/onefetch/pull/254

Comments

Post a Comment

Popular posts from this blog

My PR for release 0.3 External Project

Image
 Picking the issue I am so glad to hear that we are allowed to work on repositories that  we have already worked on in the past. That means we don't need to spend time on set it up and learn the code. I decide to work on  issue-collab  since I am so familiar with the repository. Different than any other issue I have work on, I filed the new issue-76 myself and tried to create a pull request for it. The issue I filed is that add a scroll to the top button. I am trying to add the scroll to the top button into this issue-collab repository just like the one in Telescope. The owner of Issue-collab thinks this is a good idea too. Working on the issue The first time when I tried to work on it, I just tried to study the code from Telescope and some from google and playing the code around. I was so annoying that I can't put some code together successfully in React. After watched some React video, I realized that there are two different components which are Class components and Function
Read more

OSD600 Lab8

Image
OSD600 LAB8 In this lab, we were asked to add unit tests, code coverage analysis, continuous integration to my open source project  urlStatusChecker .  we were also asked to add Tests to Another project. Choose and Set Up a Testing Framework Since my command-line tool is written in javascript, I choose Jest as my testing framework. It is a famous javascript testing framework that works with projects using: Babel, Typescript, Node, React, Angular, Vue, etc. I  know that Jest contains a code coverage analysis as well, so it is the perfect option. I simply use the command " npm install --save-dev jest " to install it and start writing my unit test. Write My First Test I have never write any unit tests before. After I watched this week's video, I have a basic concept of what is unit testing, integration testing, end to end testing. I chose the  simplest   function  in my project to begin to write my first unit test.  const   goodUrl  = ( urlString )  =>  {    const   PATT
Read more

OSD600 -- Release 0.4.1 -- Choose Project and issues

Release 0.4.1 -- Choose Project and issues For this release 0.4, we keep contributing to the open-source projects with larger/more pull requests. The next couple weeks would be very busy for me and I don't want to spend too much time on finding projects, and setting developer environments, so  I chose to keep contribute to  Telescope  for my last release. I have checked all the issues on the Telescope repository, and I found one I really want to work on Issue-1416  Improve Mobile Usability by adding a bottom app bar Sadly, it was picked by one of my classmates.  However, there are some front-end enhancements/bugs that I can work on.  I will start my release 0.4 by adding/fixing those  enhancements/bugs and keep finding all  related   enhancements/bugs to improve the overall front-end of the project. These are the issues I am currently working on: Issue-1424  Fix font colours in GitHub Contributor component Issue-1426   Scroll To Top button doesn't move to correct position Issue
Read more