My fouth PR request for Hacktoberfest

 Picking the Issue

I have spent a lot of time finding an issue that I am capable to work on this time. I feel that I am so bad at self-learning. I looked at quite a few issues and tried to work on it but I just can't understand them even I googled and tested a lot. Finally, I gave up on adding a new feather for my fourth pull request. Instead, I decided to contribute to the project mattermost which larger than my previous projects. 

The issue-16167 basically just convert all the file under a component from Javascript to Typescripts. The member of the project also provides the checklist for the migration.

  • < ] Rename the files to their associated TypeScript extensions (ie. js to ts, jsx to tsx)
  •   Update any components using those to the correct imports
  • [ > Fix any errors generated by the TypeScript compiler. You can run make check-types to display any errors
Working on the issue

Firstly, I changed some all 4 files extension from js to ts, jsx to tsx. After I done that, there are a few compile errors show up. Such as:

Parameter 'props' implicitly has an 'any' type.

Property 'serverVersionOnAppLoad' does not exist on type 'Readonly<{}> & Readonly<{ children?: ReactNode; }>'.

roperty 'serverVersion' does not exist on type 'Readonly<{}>'

 After I googled the errors, I noticed that the most difference between Javascript and Typescript is that Typescript is more sensitive to the datatype. I created two interfaces to define the datatype of some variables.

interface IMyComponentProps {
    serverVersion?: string,
}

interface IMyComponentState {
    serverVersionOnAppLoad?: string,
}

then add them into the Class

export default class VersionBar extends React.PureComponent <IMyComponentProps, 
IMyComponentState>

Then, I changed a few variable's data-type using those interfaces. 

I delete the line import PropTypes from 'prop-types';  since typescript no longer need it.

I also changed a function's parameter type from string to string | undefined from another file because a dependency function only takes the string | undefined type. 

Sending pull request

when I sent a draft pull first to check will my code pass all the tests, I got 4 errors that from some formatting. I fixed it and set my pull request to ready for review, it passed all the tests. However, I still have no confidence that my code will actually work because I can not find where is my component (version bar) on the website. After one of the reviewers reviewed my code, I fixed some problems he mentioned, then he approved my pull request. I am still waiting for the merge after the approval. 

Comments

Post a Comment

Popular posts from this blog

My third pull request for Hacktoberfest

Image
Picking the Issue Since I never deal with bugs for my first and second pull request, I decided to find a bug issue to work for my third pull request. The funny thing is that I just noticed that one of the contributors of my second PR's project  issue-collab  listed a bug about " Page not reloading after clicking next on pagination ". The owner of the repo wants someone to share a video/gif about the issue because he not really clear what the bug exactly is. I tried and uploaded the gif of the bug.  Then the owner reproduced it as following: Click Find Issues Scroll to bottom of page and click Next page Click Find Issues again (observe it doesn't work) Click Find Issues a second time (observe it loads the first page) I asked him assigned the issue to me and he did it immediately. Practice the git commands I checked the requirement of release 0.2, and I am able to work on at least 3 different repos for my PR. That means I can work on this repo twice plus 2 more differe...
Read more

OSD Lab3 Git Merge

Image
In this lab, I need to implement two additional feathers into my release 0.1 project --  urlStatusChecker . I am asked to do each of the feathers in its own branch and then merge them into my master branch in order to learn and get familiar with the git merge processes. I choose to add two of the following  features into my   urlStatusChecker : Add a  -j ,  --json , and/or  \j  flag, which causes the program to output JSON. The JSON output should look like  [ { url: 'https://www.google.com': status '200' }, { url: 'https://bad-link.com': status: '404' } ] Support  --all ,  --good , and  --bad  flags. The  --all  flag is the default, and if none of these are present, it will display good and bad URLs. The  --good  flag causes only good URLs to get displayed; the  --bad  flag causes only bad URLs to get displayed To begin with, I issued the two feathers that I wanted to add in my repository(...
Read more

My PR for release 0.3 External Project

Image
 Picking the issue I am so glad to hear that we are allowed to work on repositories that  we have already worked on in the past. That means we don't need to spend time on set it up and learn the code. I decide to work on  issue-collab  since I am so familiar with the repository. Different than any other issue I have work on, I filed the new issue-76 myself and tried to create a pull request for it. The issue I filed is that add a scroll to the top button. I am trying to add the scroll to the top button into this issue-collab repository just like the one in Telescope. The owner of Issue-collab thinks this is a good idea too. Working on the issue The first time when I tried to work on it, I just tried to study the code from Telescope and some from google and playing the code around. I was so annoying that I can't put some code together successfully in React. After watched some React video, I realized that there are two different components which are Class compone...
Read more