OSD 600 LAB4

About Lab4

In this lab, I am going to add ignore URL Patterns to one of my classmate's URL command-line tool project. For example,  if you write 'https://www.google.com" in the text file (ignore-urls.txt), then run the command "$ tool-name --ignore ignore-urls.txt index.html".  Your tool will check all URLs in index.html, but ignore the URLs in ignore-url.txt which is "https://www.google.com" in this case. I am also asked to practice using git remote and sharing commits with git push, git pull,git fetch and git merge. 

Getting start

Since our professor prefers us to work on the repo we haven't worked on before, I picked Hyunji Lee's repo URL-FI which is also written in javascript from the 0.1 Submissions list. 

I filled up the Issue-12 for the new ignore feather. After I cloned the repo and tried to test some commands, I found that the tool isn't working properly. 



I console.log something out and find the program stops at fs.readFile. I tried to solve the program for a while but couldn't figure it out. Therefore, I asked Hyunji about the problem I found on the Issue-12, it turns out it's an exit code issue, and she fixed it really quickly. 

Implement the feather

The feather is not hard, I made the ignore flag first. If the argument is --i or --ignore, it will set the ignore flag to true. If the ignore flag is true, it will read the next file after the --ignore argument, and store all the URLs in that file into an array. After reading the second file, I used the filter function to compare and filter the duplicate URLs in both arrays. 


Problem I got

Hyunji checks my code carefully and points out some bugs I have in my PR. 

The first problem I got is the readFile is not work synchronously. Sometimes it runs the second readFile before the first readFile ends. I simply change the readFile to readFileSync to prevent the readFile read before read ignored file ends.

I also forget to code that treat '#' as a comment. I implemented this functionality Hyunji pointed out.

I was terrified When Hyunji told me third times that my code is not working properly again. However, it turns out that she was running her own code instead of mine.

Lab 4 remote command practice

After Wei-J-Huang adds the ignore feather to my repo, I use the command "remote add Wei-J-Huang https://github.com/Wei-J-Huang/urlStatusChecker.git" to add the remote to my local repo, then "git fetch Wei-J-Huang" to fetch the remote repo. Then I set up a tracking branch checkout -b Wei-J-Huang/issue-7 for testing his code.
 
I discuss some problems with Huang on slack. After he added the warning of Ignored file format, I fetch then pull the remote repo again, then merge it to my master branch.

Links for the Repo, issue, and PR




Comments

Post a Comment

Popular posts from this blog

My PR for release 0.3 External Project

Image
 Picking the issue I am so glad to hear that we are allowed to work on repositories that  we have already worked on in the past. That means we don't need to spend time on set it up and learn the code. I decide to work on  issue-collab  since I am so familiar with the repository. Different than any other issue I have work on, I filed the new issue-76 myself and tried to create a pull request for it. The issue I filed is that add a scroll to the top button. I am trying to add the scroll to the top button into this issue-collab repository just like the one in Telescope. The owner of Issue-collab thinks this is a good idea too. Working on the issue The first time when I tried to work on it, I just tried to study the code from Telescope and some from google and playing the code around. I was so annoying that I can't put some code together successfully in React. After watched some React video, I realized that there are two different components which are Class components and Function
Read more

OSD600 Lab8

Image
OSD600 LAB8 In this lab, we were asked to add unit tests, code coverage analysis, continuous integration to my open source project  urlStatusChecker .  we were also asked to add Tests to Another project. Choose and Set Up a Testing Framework Since my command-line tool is written in javascript, I choose Jest as my testing framework. It is a famous javascript testing framework that works with projects using: Babel, Typescript, Node, React, Angular, Vue, etc. I  know that Jest contains a code coverage analysis as well, so it is the perfect option. I simply use the command " npm install --save-dev jest " to install it and start writing my unit test. Write My First Test I have never write any unit tests before. After I watched this week's video, I have a basic concept of what is unit testing, integration testing, end to end testing. I chose the  simplest   function  in my project to begin to write my first unit test.  const   goodUrl  = ( urlString )  =>  {    const   PATT
Read more

OSD600 -- Release 0.4.1 -- Choose Project and issues

Release 0.4.1 -- Choose Project and issues For this release 0.4, we keep contributing to the open-source projects with larger/more pull requests. The next couple weeks would be very busy for me and I don't want to spend too much time on finding projects, and setting developer environments, so  I chose to keep contribute to  Telescope  for my last release. I have checked all the issues on the Telescope repository, and I found one I really want to work on Issue-1416  Improve Mobile Usability by adding a bottom app bar Sadly, it was picked by one of my classmates.  However, there are some front-end enhancements/bugs that I can work on.  I will start my release 0.4 by adding/fixing those  enhancements/bugs and keep finding all  related   enhancements/bugs to improve the overall front-end of the project. These are the issues I am currently working on: Issue-1424  Fix font colours in GitHub Contributor component Issue-1426   Scroll To Top button doesn't move to correct position Issue
Read more