Second PR for Hacktoberfest

Picking the Issue

The first issue I was working on is that reduce the size of an ASCII logo of onefetch repository. Even I download Rust for testing my logo, it still not much related to programming. Therefore, this time I decided to find an issue that at least do something programming stuff. I spent a while for finding the second issue, and I find this interesting repo issue-collab. This is a React web-app that does similar functionality as Github search with better-looking UI. 


There was an issue-57 posted from one of their contributors, and he thinks it would be a good idea to show the number of comments in issues. The owner of the repo agreed that and opened this to anyone. He also kindly give some advice on how to add the numbers of comments.


Working on the Issue

After I set up everything (fork, clone, branch), I followed the advice checking is the function 
getIssues() in App.tsx  returns this data already. I console.log() the result returned by getIssues() function, and it turned out that it includes data of comments too.

Since they already fetch the number of comments in their function. I just need to get the data from the returned result 
 



Add show them out by adding the comments attribute to searchResult component. 

After I edited both searchResult and rearchResultContainer, I added the CSS to right-align the number of comments.


Sending the PR

After I sent my PR add number of comments #65, the owner pointed out that there are errors in the deploy preview, and he also has some merge conflict. I guess the problem cause the errors and merge conflict is that I ran the auto-formatting command "npm run lint:fix" from their contributing instruction, and the command changed some format in some files. The problem fixed when I reset those changed files to their original status, and my PR was merged into the master branch.

Links

the Repo issue-collab: https://github.com/tianlangwu/issue-collab

the Issue issue-57: https://github.com/trybick/issue-collab/issues/57

the PR PR-65: https://github.com/trybick/issue-collab/pull/65

















Comments

Post a Comment

Popular posts from this blog

My third pull request for Hacktoberfest

Image
Picking the Issue Since I never deal with bugs for my first and second pull request, I decided to find a bug issue to work for my third pull request. The funny thing is that I just noticed that one of the contributors of my second PR's project  issue-collab  listed a bug about " Page not reloading after clicking next on pagination ". The owner of the repo wants someone to share a video/gif about the issue because he not really clear what the bug exactly is. I tried and uploaded the gif of the bug.  Then the owner reproduced it as following: Click Find Issues Scroll to bottom of page and click Next page Click Find Issues again (observe it doesn't work) Click Find Issues a second time (observe it loads the first page) I asked him assigned the issue to me and he did it immediately. Practice the git commands I checked the requirement of release 0.2, and I am able to work on at least 3 different repos for my PR. That means I can work on this repo twice plus 2 more differe...
Read more

OSD Lab3 Git Merge

Image
In this lab, I need to implement two additional feathers into my release 0.1 project --  urlStatusChecker . I am asked to do each of the feathers in its own branch and then merge them into my master branch in order to learn and get familiar with the git merge processes. I choose to add two of the following  features into my   urlStatusChecker : Add a  -j ,  --json , and/or  \j  flag, which causes the program to output JSON. The JSON output should look like  [ { url: 'https://www.google.com': status '200' }, { url: 'https://bad-link.com': status: '404' } ] Support  --all ,  --good , and  --bad  flags. The  --all  flag is the default, and if none of these are present, it will display good and bad URLs. The  --good  flag causes only good URLs to get displayed; the  --bad  flag causes only bad URLs to get displayed To begin with, I issued the two feathers that I wanted to add in my repository(...
Read more

My PR for release 0.3 External Project

Image
 Picking the issue I am so glad to hear that we are allowed to work on repositories that  we have already worked on in the past. That means we don't need to spend time on set it up and learn the code. I decide to work on  issue-collab  since I am so familiar with the repository. Different than any other issue I have work on, I filed the new issue-76 myself and tried to create a pull request for it. The issue I filed is that add a scroll to the top button. I am trying to add the scroll to the top button into this issue-collab repository just like the one in Telescope. The owner of Issue-collab thinks this is a good idea too. Working on the issue The first time when I tried to work on it, I just tried to study the code from Telescope and some from google and playing the code around. I was so annoying that I can't put some code together successfully in React. After watched some React video, I realized that there are two different components which are Class compone...
Read more