Second PR for Hacktoberfest

Picking the Issue

The first issue I was working on is that reduce the size of an ASCII logo of onefetch repository. Even I download Rust for testing my logo, it still not much related to programming. Therefore, this time I decided to find an issue that at least do something programming stuff. I spent a while for finding the second issue, and I find this interesting repo issue-collab. This is a React web-app that does similar functionality as Github search with better-looking UI. 


There was an issue-57 posted from one of their contributors, and he thinks it would be a good idea to show the number of comments in issues. The owner of the repo agreed that and opened this to anyone. He also kindly give some advice on how to add the numbers of comments.


Working on the Issue

After I set up everything (fork, clone, branch), I followed the advice checking is the function 
getIssues() in App.tsx  returns this data already. I console.log() the result returned by getIssues() function, and it turned out that it includes data of comments too.

Since they already fetch the number of comments in their function. I just need to get the data from the returned result 
 



Add show them out by adding the comments attribute to searchResult component. 

After I edited both searchResult and rearchResultContainer, I added the CSS to right-align the number of comments.


Sending the PR

After I sent my PR add number of comments #65, the owner pointed out that there are errors in the deploy preview, and he also has some merge conflict. I guess the problem cause the errors and merge conflict is that I ran the auto-formatting command "npm run lint:fix" from their contributing instruction, and the command changed some format in some files. The problem fixed when I reset those changed files to their original status, and my PR was merged into the master branch.

Links

the Repo issue-collab: https://github.com/tianlangwu/issue-collab

the Issue issue-57: https://github.com/trybick/issue-collab/issues/57

the PR PR-65: https://github.com/trybick/issue-collab/pull/65

















Comments

Post a Comment

Popular posts from this blog

My PR for release 0.3 External Project

Image
 Picking the issue I am so glad to hear that we are allowed to work on repositories that  we have already worked on in the past. That means we don't need to spend time on set it up and learn the code. I decide to work on  issue-collab  since I am so familiar with the repository. Different than any other issue I have work on, I filed the new issue-76 myself and tried to create a pull request for it. The issue I filed is that add a scroll to the top button. I am trying to add the scroll to the top button into this issue-collab repository just like the one in Telescope. The owner of Issue-collab thinks this is a good idea too. Working on the issue The first time when I tried to work on it, I just tried to study the code from Telescope and some from google and playing the code around. I was so annoying that I can't put some code together successfully in React. After watched some React video, I realized that there are two different components which are Class components and Function
Read more

OSD600 Lab8

Image
OSD600 LAB8 In this lab, we were asked to add unit tests, code coverage analysis, continuous integration to my open source project  urlStatusChecker .  we were also asked to add Tests to Another project. Choose and Set Up a Testing Framework Since my command-line tool is written in javascript, I choose Jest as my testing framework. It is a famous javascript testing framework that works with projects using: Babel, Typescript, Node, React, Angular, Vue, etc. I  know that Jest contains a code coverage analysis as well, so it is the perfect option. I simply use the command " npm install --save-dev jest " to install it and start writing my unit test. Write My First Test I have never write any unit tests before. After I watched this week's video, I have a basic concept of what is unit testing, integration testing, end to end testing. I chose the  simplest   function  in my project to begin to write my first unit test.  const   goodUrl  = ( urlString )  =>  {    const   PATT
Read more

OSD600 -- Release 0.4.1 -- Choose Project and issues

Release 0.4.1 -- Choose Project and issues For this release 0.4, we keep contributing to the open-source projects with larger/more pull requests. The next couple weeks would be very busy for me and I don't want to spend too much time on finding projects, and setting developer environments, so  I chose to keep contribute to  Telescope  for my last release. I have checked all the issues on the Telescope repository, and I found one I really want to work on Issue-1416  Improve Mobile Usability by adding a bottom app bar Sadly, it was picked by one of my classmates.  However, there are some front-end enhancements/bugs that I can work on.  I will start my release 0.4 by adding/fixing those  enhancements/bugs and keep finding all  related   enhancements/bugs to improve the overall front-end of the project. These are the issues I am currently working on: Issue-1424  Fix font colours in GitHub Contributor component Issue-1426   Scroll To Top button doesn't move to correct position Issue
Read more