OSD600 -- Release 0.4.2

 OSD600 -- Release 0.4.2

In my preview blog, I have listed a couple of issues from telescope repository that I am currently working on. They are 

The first PR I have done is that fix colours in Github Contributor component.

I found the color property inside the link was set to text.secondary(lightBlue). I changed it to primary.contrastText(white). Then I removed the hover effect and the text-decoration to underline. 
so the colour of the Contributor component from

Screen Shot 2020-11-19 at 6 43 44 PM
to 


I also removed are an unused variable and fix a linter error in the file. I fixed a tag from 
href={'https://github.com/Seneca-CDOT/telescope/commits?author=' + contributor.login} to
href={`https://github.com/Seneca-CDOT/telescope/commits?author=${contributor.login}`}. 

I learned the syntax of @material-ui from this PR. I also learned that ${varible} is safer than + variable from the linter error.

The Second PR I have done is adding the Back to Top button to the search page for Long search results.

After Study the code in BackToTopButton and ScrollAction component, I found that all the functions for scrolls are built already, all I need to do is add the BackToTopButton component to the search component and add the specific id to an element as an anchor. I found that in the banner component, 

<div id="back-to-top-anchor" />

there is a div with id "back-to-top-anchor". I used the same id for my div elements in the search page component. After that, I studied from other components that how to add CSS of @material-ui to the component, then add CSS to move the scroll to the very top of the screen 

import { makeStyles } from '@material-ui/core/styles';
const useStyles = makeStyles(() => ({
  anchor: {
    position: 'absolute',
    top: 0,
  },
}));
const classes = useStyles();

<div className={classes.anchor} id="back-to-top-anchor"></div>

From the PR, I learend how to add CSS of @material-ui to the project, and the overall design of scroll to top/scroll action component. It helped me to quickly solve other css and scroll action bugs in the next a few issues.

The third PR I have done is that Fix Scroll To Top button doesn't move to the correct position.

Screen Shot 2020-11-19 at 7 13 00 PM



Firstly, I quickly located that the anchor of the scroll action is in the Banner Component. Since I just studied how the scroll action works in Telescope, and the CSS of @material-ui. I fix this issue quickly by creating a CSS class named anchor and adjust its proper position. 

Now it moves to the proper position like this 




Comments

Post a Comment

Popular posts from this blog

My PR for release 0.3 External Project

Image
 Picking the issue I am so glad to hear that we are allowed to work on repositories that  we have already worked on in the past. That means we don't need to spend time on set it up and learn the code. I decide to work on  issue-collab  since I am so familiar with the repository. Different than any other issue I have work on, I filed the new issue-76 myself and tried to create a pull request for it. The issue I filed is that add a scroll to the top button. I am trying to add the scroll to the top button into this issue-collab repository just like the one in Telescope. The owner of Issue-collab thinks this is a good idea too. Working on the issue The first time when I tried to work on it, I just tried to study the code from Telescope and some from google and playing the code around. I was so annoying that I can't put some code together successfully in React. After watched some React video, I realized that there are two different components which are Class components and Function
Read more

OSD600 Lab8

Image
OSD600 LAB8 In this lab, we were asked to add unit tests, code coverage analysis, continuous integration to my open source project  urlStatusChecker .  we were also asked to add Tests to Another project. Choose and Set Up a Testing Framework Since my command-line tool is written in javascript, I choose Jest as my testing framework. It is a famous javascript testing framework that works with projects using: Babel, Typescript, Node, React, Angular, Vue, etc. I  know that Jest contains a code coverage analysis as well, so it is the perfect option. I simply use the command " npm install --save-dev jest " to install it and start writing my unit test. Write My First Test I have never write any unit tests before. After I watched this week's video, I have a basic concept of what is unit testing, integration testing, end to end testing. I chose the  simplest   function  in my project to begin to write my first unit test.  const   goodUrl  = ( urlString )  =>  {    const   PATT
Read more

OSD600 -- Release 0.4.1 -- Choose Project and issues

Release 0.4.1 -- Choose Project and issues For this release 0.4, we keep contributing to the open-source projects with larger/more pull requests. The next couple weeks would be very busy for me and I don't want to spend too much time on finding projects, and setting developer environments, so  I chose to keep contribute to  Telescope  for my last release. I have checked all the issues on the Telescope repository, and I found one I really want to work on Issue-1416  Improve Mobile Usability by adding a bottom app bar Sadly, it was picked by one of my classmates.  However, there are some front-end enhancements/bugs that I can work on.  I will start my release 0.4 by adding/fixing those  enhancements/bugs and keep finding all  related   enhancements/bugs to improve the overall front-end of the project. These are the issues I am currently working on: Issue-1424  Fix font colours in GitHub Contributor component Issue-1426   Scroll To Top button doesn't move to correct position Issue
Read more